oadm policy reconcile-sccs: update comments and help text #13702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pweil-
reviewed
Apr 10, 2017
| will not remove additional users and groups that have been granted access to the SCC and | ||
| will preserve existing priorities (but will always reconcile unset priorities and the policy | ||
| definition). | ||
| will not remove additional users, groups, labels and annotations that have been granted |
There was a problem hiding this comment.
labels and annotations are not granted access to the SCC, suggest rewording
There was a problem hiding this comment.
Good catch! I've fixed it.
php-coder
force-pushed
the
oadm_policy_reconcile-sccs_consistency
branch
from
749e152
to
e15a954
Compare
|
[test][merge] |
|
Evaluated for origin merge up to e15a954 |
|
Evaluated for origin test up to e15a954 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/676/) (Base Commit: 585b160) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/308/) (Base Commit: 445ae00) (Image: devenv-rhel7_6134) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up improvements to #6714
PTAL @pweil-