-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <carry>: Fix to avoid REST API calls at log level 2. #13844
UPSTREAM: <carry>: Fix to avoid REST API calls at log level 2. #13844
Conversation
Commit message is incorrect. Needs to be |
6e6012c
to
79a7371
Compare
@ncdc fixed hopefully it is correct this time. |
LGTM [merge] |
[Test]ing while waiting on the merge queue |
[test][merge] from whole internet being dead |
[test] [merge] |
(FYI, i think they have merge turned off for rebase) |
@eparis -- thanks for the reminder, i was being dense. |
@eparis is there a merge-cancel action? |
i think they just turned it off. so you can leave the tag. |
@aveshagarwal please rebase. New file location is vendor/k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/server/httplog/log.go |
79a7371
to
ffead55
Compare
@ncdc fixed it. Thanks. |
[merge] |
Evaluated for origin merge up to ffead55 |
Evaluated for origin test up to ffead55 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1124/) (Base Commit: d97afdf) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/552/) (Base Commit: fb32130) (Image: devenv-rhel7_6207) |
Automatic merge from submit-queue (batch tested with PRs 16089, 16305, 16219, 15934, 16366) UPSTREAM: <carry>: Fix to avoid REST API calls at log level 2. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1484095. Its a regression in origin master (3.7). @sjenning This PR is carry because the previous PR to 3.6 was carry too (#13844) due to uncertainty around upstream PR (kubernetes/kubernetes#40933). @stevekuznetsov @deads2k Also is something broken in the rebase process or any related scripts that previous carry PR (#13844) was dropped? Not to blame anyone, just informing as I am wondering if there are other carry PRs that got dropped and we are not aware causing regressions in future, so that if something is broken (process or script), can be fixed.
@derekwaynecarr @eparis
Fix https://bugzilla.redhat.com/show_bug.cgi?id=1414813