-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RWO warning with percentages #15422
Conversation
Signed-off-by: Michail Kargakis <mkargaki@redhat.com>
do we have test exercising this? LGTM |
@mfojtik see the fixture change [test] |
Evaluated for origin test up to d00a7fe |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3439/) (Base Commit: 883e926) (PR Branch Commit: d00a7fe) |
[merge] |
Evaluated for origin merge up to d00a7fe |
Labelling this PR as size/S |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1376/) (Base Commit: 49df2d6) (PR Branch Commit: d00a7fe) (Image: devenv-rhel7_6479) |
/cherrypick release-1.5 |
@Kargakis: New pull request created: #16903 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-3.6 |
New pull request created: #16949 |
/cherrypick release-3.6 |
Failed to push cherry-picked changes in Github: exit status 1 |
@Kargakis shouldn't the response here also tell you it's responding to your comment with the command? |
@mfojtik fixes the warning since the default case (25%-25%) is broken.
/assign mfojtik