Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RWO warning with percentages #15422

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Fix RWO warning with percentages #15422

merged 1 commit into from
Jul 25, 2017

Conversation

0xmichalis
Copy link
Contributor

@mfojtik fixes the warning since the default case (25%-25%) is broken.

/assign mfojtik

@0xmichalis
Fix RWO warning with percentages
d00a7fe 
Signed-off-by: Michail Kargakis <mkargaki@redhat.com>
@mfojtik
Copy link
Contributor

mfojtik commented Jul 24, 2017

do we have test exercising this?

LGTM

@0xmichalis
Copy link
Contributor Author

@mfojtik see the fixture change

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to d00a7fe

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3439/) (Base Commit: 883e926) (PR Branch Commit: d00a7fe)

@0xmichalis
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to d00a7fe

@openshift-merge-robot
Copy link
Contributor

Labelling this PR as size/S

@openshift-merge-robot openshift-merge-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 24, 2017
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 25, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1376/) (Base Commit: 49df2d6) (PR Branch Commit: d00a7fe) (Image: devenv-rhel7_6479)

@openshift-bot openshift-bot merged commit 970dc61 into openshift:master Jul 25, 2017
@0xmichalis 0xmichalis deleted the fix-rwo-warning branch July 25, 2017 08:03
@0xmichalis
Copy link
Contributor Author

/cherrypick release-1.5

@ghost
Copy link

ghost commented Oct 17, 2017

@Kargakis: New pull request created: #16903

In response to this:

@mfojtik fixes the warning since the default case (25%-25%) is broken.

/assign mfojtik

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xmichalis 0xmichalis mentioned this pull request Oct 17, 2017
Merged
@0xmichalis
Copy link
Contributor Author

/cherrypick release-3.6

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 19, 2017
Closed
@openshift-ci-robot
Copy link

New pull request created: #16949

@0xmichalis 0xmichalis mentioned this pull request Oct 20, 2017
Merged
@0xmichalis
Copy link
Contributor Author

/cherrypick release-3.6

@openshift-ci-robot
Copy link

Failed to push cherry-picked changes in Github: exit status 1

@stevekuznetsov
Copy link
Contributor

@Kargakis shouldn't the response here also tell you it's responding to your comment with the command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xmichalis @mfojtik @openshift-bot @openshift-merge-robot @openshift-ci-robot @stevekuznetsov