-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy: remove deprecated generatedeploymentconfig api #15585
deploy: remove deprecated generatedeploymentconfig api #15585
Conversation
Superseded by instantiate ever since 3.4. |
/test cross |
5eab803
to
c0d0204
Compare
updated bootstrap policy test |
@Kargakis all green, ship this? (after this merge, I will send mail to aos lists and update the openshift-docs issue) |
@@ -51,7 +51,7 @@ var ( | |||
groupsToResources = map[string][]string{ | |||
buildGroupName: {"builds", "buildconfigs", "buildlogs", "buildconfigs/instantiate", "buildconfigs/instantiatebinary", "builds/log", "builds/clone", "buildconfigs/webhooks"}, | |||
imageGroupName: {"imagestreams", "imagestreammappings", "imagestreamtags", "imagestreamimages", "imagestreamimports"}, | |||
deploymentGroupName: {"deploymentconfigs", "generatedeploymentconfigs", "deploymentconfigrollbacks", "deploymentconfigs/log", "deploymentconfigs/scale"}, | |||
deploymentGroupName: {"deploymentconfigs", "deploymentconfigrollbacks", "deploymentconfigs/log", "deploymentconfigs/scale"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to deprecate deploymentconfigrollbacks
too in favor of deploymentconfigs/rollback
but it's a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 i saw it in master config but want to track that as separate thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this tracked anywhere?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kargakis, mfojtik No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 15585, 15561) |
Needs a deprecation notice in openshift/openshift-docs#4906
Need public announcement.
Need a release notes.
According to @Kargakis this API is not used at all so we should nuke it.