deploy: remove deprecated generatedeploymentconfig api #15585
Conversation
openshift-merge-robot
added
the
size/XL
openshift-merge-robot
added
the
approved
|
Superseded by instantiate ever since 3.4. |
|
/test cross |
mfojtik
force-pushed
the
deprecate-generator
branch
from
5eab803
to
c0d0204
Compare
|
updated bootstrap policy test |
mfojtik
changed the title
|
@Kargakis all green, ship this? (after this merge, I will send mail to aos lists and update the openshift-docs issue) |
| @@ -51,7 +51,7 @@ var ( | |||
| groupsToResources = map[string][]string{ | |||
| buildGroupName: {"builds", "buildconfigs", "buildlogs", "buildconfigs/instantiate", "buildconfigs/instantiatebinary", "builds/log", "builds/clone", "buildconfigs/webhooks"}, | |||
| imageGroupName: {"imagestreams", "imagestreammappings", "imagestreamtags", "imagestreamimages", "imagestreamimports"}, | |||
| deploymentGroupName: {"deploymentconfigs", "generatedeploymentconfigs", "deploymentconfigrollbacks", "deploymentconfigs/log", "deploymentconfigs/scale"}, | |||
| deploymentGroupName: {"deploymentconfigs", "deploymentconfigrollbacks", "deploymentconfigs/log", "deploymentconfigs/scale"}, | |||
There was a problem hiding this comment.
We probably want to deprecate deploymentconfigrollbacks too in favor of deploymentconfigs/rollback but it's a separate issue.
There was a problem hiding this comment.
+1 i saw it in master config but want to track that as separate thing
There was a problem hiding this comment.
Is this tracked anywhere?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kargakis, mfojtik No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 15585, 15561) |
Needs a deprecation notice in openshift/openshift-docs#4906
Need public announcement.
Need a release notes.
According to @Kargakis this API is not used at all so we should nuke it.