-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] switch router to watch using shared informer #15645
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rajatchopra Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
1f54e81
to
b9aeeb0
Compare
go utilwait.Forever(c.HandleEndpoints, 0) | ||
|
||
c.StartRouteWatch(cache.ResourceEventHandlerFuncs{ | ||
AddFunc: func(obj interface{}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at RegisterSharedInformerEventHandlers() in pkg/sdn/plugin/common.go
We could do similar stuff here and that will reduce code duplication for all the router watch resources.
b9aeeb0
to
008984a
Compare
/test extended_networking |
/retest |
008984a
to
73c2c72
Compare
@rajatchopra: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@rajatchopra PR needs rebase |
@rajatchopra: Your pull request title starts with "[WIP]", so the do-not-merge/work-in-progress label will be added. This label will ensure that your pull request will not be merged. Remove the prefix from your pull request title to trigger the removal of the label and allow for your pull request to be merged. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing this PR in favor of #16315 |
First cut. Still a work in progress.
Mostly working, but needs: