Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] switch router to watch using shared informer #15645

Closed
wants to merge 1 commit into from
Closed

[WIP] switch router to watch using shared informer #15645

wants to merge 1 commit into from

Conversation

rajatchopra
Copy link
Contributor

@rajatchopra rajatchopra commented Aug 5, 2017 •
edited

First cut. Still a work in progress.
Mostly working, but needs:

  • Functional testing
  • Stress testing to cover reloading/coalescing
  • Code cleanup

@openshift-merge-robot openshift-merge-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 5, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rajatchopra
We suggest the following additional approver: smarterclayton

Assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

pravisankar
pravisankar reviewed Aug 8, 2017
View reviewed changes
pkg/router/controller/router_controller.go
go utilwait.Forever(c.HandleEndpoints, 0)

c.StartRouteWatch(cache.ResourceEventHandlerFuncs{
AddFunc: func(obj interface{}) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at RegisterSharedInformerEventHandlers() in pkg/sdn/plugin/common.go
We could do similar stuff here and that will reduce code duplication for all the router watch resources.

@rajatchopra
Copy link
Contributor Author

/test extended_networking

@rajatchopra
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

@rajatchopra: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration 73c2c72 link /test integration
ci/openshift-jenkins/end_to_end 73c2c72 link /test end_to_end
ci/openshift-jenkins/extended_conformance_install_update 73c2c72 link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

@rajatchopra PR needs rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2017
@stevekuznetsov stevekuznetsov changed the title [WIP] switch router to watch using shared informer [WIP] switch router to watch using shared informer Sep 7, 2017
@openshift-ci-robot
Copy link

@rajatchopra: Your pull request title starts with "[WIP]", so the do-not-merge/work-in-progress label will be added.

This label will ensure that your pull request will not be merged. Remove the prefix from your pull request title to trigger the removal of the label and allow for your pull request to be merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2017
@pravisankar
Copy link

Closing this PR in favor of #16315

@rajatchopra rajatchopra deleted the router_informer branch November 7, 2017 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravisankar pravisankar pravisankar left review comments

Assignees

@fabianofranz fabianofranz

@smarterclayton smarterclayton

Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rajatchopra @openshift-merge-robot @openshift-ci-robot @pravisankar @fabianofranz @smarterclayton