Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 49640: Run mount in its own systemd scope #15725

Merged

Conversation

jsafrane
Copy link
Contributor

This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1423640 (targeted to 3.6.x) - we need to fix 3.7 too.

@openshift-merge-robot openshift-merge-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 10, 2017
@jsafrane
Copy link
Contributor Author

/assign eparis
for approval

@jsafrane
Copy link
Contributor Author

/retest

2 similar comments
@jsafrane
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Contributor Author

/retest

@rootfs
Copy link
Member

rootfs commented Sep 12, 2017

[merge]

@rootfs
Copy link
Member

rootfs commented Sep 12, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2017
@rootfs
Copy link
Member

rootfs commented Sep 12, 2017

/approve

1 similar comment
@childsb
Copy link
Contributor

childsb commented Sep 12, 2017

/approve

@rootfs rootfs added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2017
@eparis
Copy link
Member

eparis commented Sep 12, 2017

/hold
/approve

remove the hold on monday when we re-open for features.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, eparis, jsafrane, rootfs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@eparis eparis removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2017
@jsafrane
Copy link
Contributor Author

/test integration
flake: #15432

@jsafrane
Copy link
Contributor Author

flake: #16317
/test cmd

@jsafrane
Copy link
Contributor Author

/test end_to_end
#16290

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor Author

flake: #16273
/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor Author

/retest
#16369

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 15, 2017

@jsafrane: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce e60c023 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15725, 16244, 15796, 16328, 16334)

@openshift-merge-robot openshift-merge-robot merged commit 682fd1b into openshift:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants