enforce context timeout on build log streaming #15944
Conversation
openshift-merge-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
@smarterclayton ptal |
bparees
changed the title
bparees
changed the title
|
/retest |
1 similar comment
|
/retest |
|
@openshift/devex ptal |
| @@ -186,6 +186,12 @@ func (r *REST) Get(ctx apirequest.Context, name string, opts runtime.Object) (ru | |||
| // until they have all run, unless we see one of them fail. | |||
| // If we aren't following the logs, we will run through all the init containers exactly once. | |||
| for waitForInitContainers { | |||
| select { | |||
| case <-ctx.Done(): | |||
| glog.V(4).Infof("timed out while iterating on build init containers for build pod %s/%s", build.Namespace, buildPodName) | |||
There was a problem hiding this comment.
iterating through build init ...
to be consistent with the wording in line 195
| glog.V(4).Infof("timed out while iterating on build init containers for build pod %s/%s", build.Namespace, buildPodName) | ||
| return | ||
| default: | ||
| } |
There was a problem hiding this comment.
I feel like line 195 should be before the select?
There was a problem hiding this comment.
we shouldn't log that we're iterating through the containers if we aren't going to iterate through the containers because the context timed out.
|
@jim-minter ptal |
|
@openshift/devex bump |
openshift-merge-robot
added
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@bparees: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 15862, 15781, 15944) |
|
/retest |
No description provided.