Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CONTRIBUTING.adoc #15972

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Updating CONTRIBUTING.adoc #15972

merged 1 commit into from
Mar 6, 2018

Conversation

PrashantSunkari
Copy link
Contributor

@PrashantSunkari
Updating CONTRIBUTING.adoc
d87e937 
- Updating the contributing doc with changes I need to do in order to run 'oc cluster up' successfully.
- Also, found few others have run into similar issue.
  Eg: https://botbot.me/freenode/openshift-dev/2017-05-25/?msg=86129314&page=5
  same Solution: https://botbot.me/freenode/openshift-dev/2017-05-25/?msg=86129367&page=5
@openshift-merge-robot openshift-merge-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2017
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 24, 2017
@openshift-ci-robot
Copy link

Hi @PrashantSunkari. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PrashantSunkari
Copy link
Contributor Author

FYI - This CL may not needed after this CL - #15959

@php-coder
Copy link
Contributor

/ok-to-test
/retest-not-required-docs-only

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 28, 2017
@php-coder
Copy link
Contributor

@stevekuznetsov Why /retest-not-required-docs-only didn't work and robot removes the label even if I put it manually?

@php-coder
Copy link
Contributor 

--- FAIL: TestRouterStatsPort (0.00s)
	router_test.go:884: Unable to start http server: listen tcp 172.18.1.247:8080: bind: address already in use

This looks like a test flake #14962

/test end_to_end

@stevekuznetsov
Copy link
Contributor

@php-coder that is not a valid command today and the label is for bots only. Humans add retest-not-required -- we can add .adoc to the doc only label

@soltysh
Copy link
Contributor

soltysh commented Aug 30, 2017

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2017
@PrashantSunkari
Copy link
Contributor Author

/assign @deads2k

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2018
soltysh
soltysh approved these changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: PrashantSunkari, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov
Copy link
Contributor

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit f1c64a4 into openshift:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. retest-not-required size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@PrashantSunkari @openshift-ci-robot @php-coder @stevekuznetsov @soltysh @openshift-bot @openshift-merge-robot @deads2k