-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test alert metadata #16026
Update test alert metadata #16026
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moolitayer Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@smarterclayton ptal |
@zgalor @ilackarms Please review |
Pending some input from @zgalor I'm thinking this test alert has two options:
|
looks good |
I'm confused why are we relaxing a valid alert with a fake one? I expect these to be real alerts. |
047ee96
to
9f4ad80
Compare
Configuring ManageIQ to receive OpenShift alerts for Prometheus alerting is not trivial. |
9f4ad80
to
bbd54a6
Compare
@smarterclayton maybe we should add the new alert commented out? |
bbd54a6
to
cff598a
Compare
ping @smarterclayton |
Why not set the annotations on the existing alert? |
@smarterclayton because I thought to have an example of a generic alert and a manageiq alert. |
I really only want real alerts here - basically let's make this only things
we would actually consider real production alerts. That way we can add
stuff and have it be focused on real use.
On Sep 3, 2017, at 8:29 AM, Mooli Tayer <notifications@github.com> wrote:
@smarterclayton <https://github.com/smarterclayton> because I thought to
have an example of a generic alert and a manageiq alert.
Would you prefer updating the one alert?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16026 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p1CjPtbBViscuTOJ7u6h5WWzT5Tvks5sepungaJpZM4PFklQ>
.
|
But they are both real now. Would you prefer I update the existing one? |
Automatic merge from submit-queue. prometheus alerts for openshift build subsystem https://trello.com/c/RskNHpfh/1334-5-prometheus-alerts-for-build-metrics A WIP initial pass at alerts for the openshift build subsystem @openshift/devex @smarterclayton @zgalor @moolitayer @mfojtik ptal, defer if bandwidth dictates, and/or pull in others as you each deem fit Disclaimers: 1) I'm still debating the pros/cons of these alerts with https://docs.google.com/document/d/199PqyG3UsyXlwieHaqbGiWVa8eMWi8zzAn0YfcApr8Q/edit#heading=h.2efurbugauf in mind 2) still debating the template parameters / defaults for the various thresholds ... I still have a to-do to revisit with ops contacts potential default values based on their existing zabbix monitoring 3) still debating the severity as well 4) based on the activity in #16026 I did not include the `miqTarget` annotation I also removed the space in the existing alert name based on how I interpreted various naming conventions. And other than the query on the alerts URI, the extended test changes stemmed from flakiness experienced during testing that was unrelated to the addition of the alerts. thanks
@moolitayer PR needs rebase |
Closing in favor of: |
The purpose of this test alert is to see that alerts are configured correctly for going into ManageIQ.
This will make it easier to see alerts are working properly straight away