Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait longer for healthz during integration tests #16040

Merged

Conversation

enj
Copy link
Contributor

@enj enj commented Aug 29, 2017

Adding post start hooks makes it take longer for the server to report that it is healthy. Thus we wait longer to ensure that the server actually failed to start.

Signed-off-by: Monis Khan mkhan@redhat.com

Adding post start hooks makes it take longer for the server to
report that it is healthy.  Thus we wait longer to ensure that the
server actually failed to start.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@openshift-merge-robot openshift-merge-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 29, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2017
@enj
Copy link
Contributor Author

enj commented Aug 29, 2017

Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj enj force-pushed the enj/t/healthz_integration_wait branch from 71ed7ba to 2b121fc Compare August 29, 2017 17:15
@openshift-merge-robot openshift-merge-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2017
@enj
Copy link
Contributor Author

enj commented Aug 29, 2017

/test unit

AWS flake

@enj
Copy link
Contributor Author

enj commented Aug 29, 2017

@stevekuznetsov why did the bot remove the approved label?

@stevekuznetsov
Copy link
Contributor

Bot's being silly

@mfojtik
Copy link
Contributor

mfojtik commented Aug 31, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16076, 16053, 16066, 16049, 16040)

@openshift-merge-robot openshift-merge-robot merged commit 83775ba into openshift:master Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants