Rename pkg/sdn to pkg/network, for consistency with its API #16057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
needs-rebase
|
/lgtm bumping queue priority because this one is going to suck to rebase. |
openshift-merge-robot
added
the
approved
|
hrm, bot didn't obey and now you have to rebase again. sorry. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
and consistently refer to pkg/network/apis/network as "networkapi"
danwinship
force-pushed
the
rename-pkg-sdn
branch
from
c0d1b79
to
e8126d2
Compare
openshift-merge-robot
removed
lgtm
|
@danwinship for rebases, it's the same old rosie rules, but you have to re-apply your tags manually. |
|
/test cmd |
|
/test extended_conformance_install_update |
|
Automatic merge from submit-queue (batch tested with PRs 16054, 16057, 15440, 16028, 16055) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deads2k wanted this
This is on top of #15781, but that should be merged soon. Only the last two commits ("Rename pkg/sdn to pkg/network, for consistency with its API" and "Regenerate files") are for this PR.