Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deployments minreadyseconds test more tolerant to infra #16061

Merged
merged 2 commits into from
Aug 31, 2017
Merged

Make deployments minreadyseconds test more tolerant to infra #16061

merged 2 commits into from
Aug 31, 2017

Conversation

tnozicka
Copy link
Contributor

Fixes #16025

Will run several test runs here to ses that the flake isn't occurring anymore.

@tnozicka
Copy link
Contributor Author

tnozicka commented Aug 30, 2017 •
edited
Loading

jenkins AWS provisioning issues:

https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_conformance_gce/6962/
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_verify/1806/

/retest

knobunc
knobunc approved these changes Aug 30, 2017
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2017
@smarterclayton
Copy link
Contributor

/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented Aug 31, 2017 •
edited
Loading

adding do-not-merge label so we can test it few times before merging.

(Not that it means much but I have been running 5 parallel instances of this test throughout the night on my laptop and each succeeded ~467 times without any flake)

@tnozicka tnozicka mentioned this pull request Aug 31, 2017
Merged
@tnozicka
Copy link
Contributor Author

round 1 passed
/test all

@0xmichalis
Copy link
Contributor

flaked on #14962

/retest

@tnozicka
Copy link
Contributor Author

e2e flaked on #14962
install_update flaked on #16072
/retest

@tnozicka
Copy link
Contributor Author

round 2 passed
/test all

@tnozicka
Copy link
Contributor Author

install_update flake #15988
/retest

@tnozicka
Copy link
Contributor Author

removing do-not-merge label since the success will be 3rd in a row

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit c080c1c into openshift:master Aug 31, 2017
@tnozicka tnozicka deleted the make-deployments-minreadyseconds-test-more-tolerant-to-infra branch November 30, 2017 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@jim-minter jim-minter

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tnozicka @openshift-merge-robot @smarterclayton @0xmichalis @knobunc @jim-minter @openshift-ci-robot