Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run the bare kube controllers #16089

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 31, 2017

This runs the kube controllers separately based on their command to avoid any customization and set us up to run them as-is, without modification in a future release (double lease thing).

@smarterclayton

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2017
@smarterclayton
Copy link
Contributor

smarterclayton commented Aug 31, 2017

I'm looking at memory numbers but I'm probably going to have to require that informers not be duplicated in 3.7 until we get other things under control. I'm ok with a clean patch that we plan on removing that provides them and uses this structure, but the memory numbers aren't good enough to do this yet.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 1, 2017

I'm looking at memory numbers but I'm probably going to have to require that informers not be duplicated in 3.7 until we get other things under control. I'm ok with a clean patch that we plan on removing that provides them and uses this structure, but the memory numbers aren't good enough to do this yet.

Why do you believe memory usage will improve going forward?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2017
@smarterclayton
Copy link
Contributor

Memory usage will improve or the beatings will continue.

@deads2k deads2k changed the title [WIP] Run the bare kube controllers run the bare kube controllers Sep 7, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Sep 7, 2017

Alright, I've create a carry patch to allow us to shim in our informers. It's ugly, but I think its better than carrying a separate config generation.

I'll make a followup to remove building the config.

/assign mfojtik

@deads2k
Copy link
Contributor Author

deads2k commented Sep 7, 2017

This doesn't work because of the multiple informer starts caused by sending our informers to the kube-controller process. This may require greater violence.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 7, 2017

Wow, green

@deads2k
Copy link
Contributor Author

deads2k commented Sep 8, 2017

etcd
/retest

@mfojtik
Copy link
Contributor

mfojtik commented Sep 15, 2017

/lgtm

Potential fix for https://bugzilla.redhat.com/show_bug.cgi?id=1491202

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2017

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd 30df806 link /test cmd
ci/openshift-jenkins/extended_networking_minimal 30df806 link /test extended_networking_minimal

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16089, 16305, 16219, 15934, 16366)

@openshift-merge-robot openshift-merge-robot merged commit dc9c4c3 into openshift:master Sep 16, 2017
@deads2k deads2k deleted the controller-10-bare-kube branch January 24, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants