Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate the imagestream.spec.DockerImageRepository field #16181

Merged
merged 1 commit into from
Sep 8, 2017
Merged

deprecate the imagestream.spec.DockerImageRepository field #16181

merged 1 commit into from
Sep 8, 2017

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Sep 6, 2017

No description provided.

@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-api-review labels Sep 6, 2017
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2017
@bparees
Copy link
Contributor Author

bparees commented Sep 6, 2017

@soltysh @smarterclayton ptal.

@jim-minter
Copy link
Contributor

@bparees hack/update-generated-swagger-descriptions.sh needed

jim-minter
jim-minter reviewed Sep 6, 2017
View reviewed changes
pkg/image/apis/image/v1/types.go Outdated
@@ -195,7 +197,8 @@ type TagReference struct {
Name string `json:"name" protobuf:"bytes,1,opt,name=name"`
// Annotations associated with images using this tag
Annotations map[string]string `json:"annotations" protobuf:"bytes,2,rep,name=annotations"`
// From is a reference to an image stream tag or image stream this tag should track
// Optional; if specified, a reference to another image that this tag should point to. Valid values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question - should the docstrings for other fields match ../types.go too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, will update.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2017
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2017
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 7, 2017
@bparees
Copy link
Contributor Author

bparees commented Sep 7, 2017

@jim-minter fixed
@openshift/api-review ptal

smarterclayton
smarterclayton reviewed Sep 7, 2017
View reviewed changes
pkg/image/apis/image/v1/types.go Outdated
@@ -173,6 +173,8 @@ type ImageStreamSpec struct {
// lookupPolicy controls how other resources reference images within this namespace.
LookupPolicy ImageLookupPolicy `json:"lookupPolicy,omitempty" protobuf:"bytes,3,opt,name=lookupPolicy"`
// dockerImageRepository is optional, if specified this stream is backed by a Docker repository on this server
// Deprecated: This field is deprecated as of v3.7 and will be removed in a future release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a period after this sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@bparees
Copy link
Contributor Author

bparees commented Sep 7, 2017 via email

@smarterclayton
Copy link
Contributor

smarterclayton commented Sep 7, 2017 via email

@bparees
Copy link
Contributor Author

bparees commented Sep 7, 2017 via email

@bparees
Copy link
Contributor Author

bparees commented Sep 7, 2017 via email

@bparees
Copy link
Contributor Author

bparees commented Sep 7, 2017

going to assume @smarterclayton's /approve qualifies as a
/lgtm

and api-approval.

@openshift-ci-robot
Copy link

@bparees: you cannot LGTM your own PR.

In response to this:

going to assume @smarterclayton's /approve qualifies as a
/lgtm

and api-approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees added lgtm Indicates that a PR is ready to be merged. and removed needs-api-review labels Sep 7, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor

smarterclayton commented Sep 7, 2017 via email

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [bparees,smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2017 •
edited
Loading

@bparees: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_builds 34dc649 link /test extended_builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2017
@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 3265c5c into openshift:master Sep 8, 2017
@bparees bparees deleted the fix_tags branch September 15, 2017 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-minter jim-minter jim-minter left review comments

@smarterclayton smarterclayton smarterclayton left review comments

Assignees

@jim-minter jim-minter

@smarterclayton smarterclayton

Labels
api-approved approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-api-review size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bparees @jim-minter @smarterclayton @openshift-ci-robot @openshift-bot @openshift-merge-robot