Separate config and options specific code for node from start #16268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
openshift-ci-robot
added
the
size/L
First refactoring towards separating out the code that launches networking from the code that launches the kubelet. Ensures that node options (the part that converts nodeconfig to kubelet config) is completely separate from how processes are started.
smarterclayton
force-pushed
the
snip_dependencies
branch
from
a00a670
to
162dd82
Compare
|
/retest |
|
Will just continue in #16269 |
openshift-merge-robot
added a commit
that referenced
this pull request
Sep 16, 2017
Automatic merge from submit-queue (batch tested with PRs 16269, 13282, 16386) Split networking out from node initialization into its own package Node and networking are now completely independent initialization paths. Builds off of #16268, only second commit is new @deads2k second step towards removing the need for node to be tied together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First refactoring towards separating out the code that launches
networking from the code that launches the kubelet. Ensures that node
options (the part that converts nodeconfig to kubelet config) is
completely separate from how processes are started.
@deads2k