ensure oc get handles mixed resource types
#16283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
enj
suggested changes
Sep 11, 2017
test/cmd/get.sh
Outdated
| os::cmd::expect_success_and_text 'oc get projectrequests -o yaml' 'status: Success' | ||
| os::cmd::expect_success_and_text 'oc get projectrequests,svc,pod -o yaml' 'kind: List' | ||
| echo "oc get: ok" | ||
| echo "oc get: ok" |
There was a problem hiding this comment.
did not mean to add it twice. Updated from s/oc get all/oc get since this does not explicitly test oc get all sub-cmd
test/cmd/get.sh
Outdated
| os::cmd::expect_success_and_text 'oc get projectrequests -o yaml' 'status: Success' | ||
| os::cmd::expect_success_and_text 'oc get projectrequests,svc,pod -o yaml' 'kind: List' | ||
| echo "oc get: ok" | ||
| echo "oc get: ok" | ||
| os::test::junit::declare_suite_end |
There was a problem hiding this comment.
Add a newline while you are here.
Adds a test to ensure `oc get` does not panic when given a list of both structured and unstructured resources.
juanvallejo
force-pushed
the
jvallejo/add-test-PR-16082
branch
from
2610f0b
to
70542a2
Compare
enj
approved these changes
Sep 11, 2017
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, juanvallejo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/test extended_conformance_install_update |
|
Automatic merge from submit-queue (batch tested with PRs 15927, 16283, 16239, 16271, 16287) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to ensure
oc getdoes not panic when given a listof both structured and unstructured resources.
Tests changes added in #16082
cc @enj @openshift/cli-review