Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename kube-gen to code-generator for syncs and picks #16288

Merged
merged 3 commits into from
Sep 12, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 11, 2017

kube-gen got renamed upstead to code-generator and we need to match to make picks work and to push out to a sync repo, which I need for client-go generation.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2017
@bparees
Copy link
Contributor

bparees commented Sep 11, 2017

/unassign

@deads2k
Copy link
Contributor Author

deads2k commented Sep 11, 2017

/assign mfojtik

@deads2k
Copy link
Contributor Author

deads2k commented Sep 12, 2017

@mfojtik think I got this verifying now.

@mfojtik
Copy link
Contributor

mfojtik commented Sep 12, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 3d2f5f8 into openshift:master Sep 12, 2017
@deads2k deads2k deleted the client-03-generator branch January 24, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants