fix remaining field selectors #16327
Conversation
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
approved
|
|
||
| func addFieldSelectorKeyConversions(scheme *runtime.Scheme) error { | ||
| return nil |
There was a problem hiding this comment.
Why this is empty?
We don't have any custom field selectors. Yet. I'm placing the skeleton here so people can more easily figure out what to do. This isn't really obvious.
|
|
||
| if err := scheme.AddFieldLabelConversionFunc("v1", "BuildConfig", apihelpers.LegacyMetaV1FieldSelectorConversionWithName); err != nil { | ||
| func addFieldSelectorKeyConversions(scheme *runtime.Scheme) error { | ||
| if err := scheme.AddFieldLabelConversionFunc(SchemeGroupVersion.String(), "Build", buildFieldSelectorKeyConversionFunc); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
No BC here?
No. BC only supports metadata, but we have the "name" -> "metadata.name" mapping for the ungroupified versions.
| "user.uid": | ||
| return label, value, nil | ||
| default: | ||
| return runtime.DefaultMetaV1FieldSelectorConversion(label, value) |
There was a problem hiding this comment.
return apihelpers.LegacyMetaV1FieldSelectorConversionWithName(label, value)?
There was a problem hiding this comment.
return apihelpers.LegacyMetaV1FieldSelectorConversionWithName(label, value)?
This one never had the "name" -> "metadata.name" mapping.
openshift-merge-robot
added
the
needs-rebase
deads2k
force-pushed
the
api-07-fieldselector
branch
from
b0282d0
to
82c48ea
Compare
openshift-merge-robot
removed
needs-rebase
|
/retest |
| } | ||
| fieldSet["spec.dockerImageRepository"] = imageStream.Spec.DockerImageRepository | ||
| fieldSet["status.dockerImageRepository"] = imageStream.Status.DockerImageRepository |
|
Automatic merge from submit-queue (batch tested with PRs 16384, 16327, 16199, 16286, 16378) |
Really hoping that #16305 works out. This updates all the rest for that pattern and allows us to remove a ton of boilerplate while maintaining decent unit test coverage. Still need a "you forgot to add a test" test, but that was already missing.