Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog: RBAC - added missing get for service-catalog-controller #16440

Merged

Conversation

jboyd01
Copy link
Contributor

@jboyd01 jboyd01 commented Sep 19, 2017

service-catalog-controller role was missing the get operation for ServiceBrokers, ServiceInstances and ServiceInstanceCredentials

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2017
@pmorie
Copy link
Contributor

pmorie commented Sep 19, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2017
@pmorie
Copy link
Contributor

pmorie commented Sep 19, 2017

This is part of #16220

@pmorie
Copy link
Contributor

pmorie commented Sep 19, 2017

/test cmd

@bparees
Copy link
Contributor

bparees commented Sep 19, 2017

gonna need to generate bindata.

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2017
@jboyd01
Copy link
Contributor Author

jboyd01 commented Sep 19, 2017

Thanks @bparees, added

@bparees
Copy link
Contributor

bparees commented Sep 19, 2017

@jboyd01 can we also add the feature flag for originating identity while we're at this?
@gabemontero @staebler

@pmorie
Copy link
Contributor

pmorie commented Sep 20, 2017

@bparees we need to cut a new release to get all of the feature flag. I'm working on that now - it will drop tomorrow into origin.

@pmorie
Copy link
Contributor

pmorie commented Sep 20, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2017
@pmorie
Copy link
Contributor

pmorie commented Sep 20, 2017

@bparees can you approve this one?

@bparees
Copy link
Contributor

bparees commented Sep 20, 2017

/approve

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jboyd01, pmorie

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2017
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2017

@jboyd01: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd ca9d312 link /test cmd
ci/openshift-jenkins/end_to_end ca9d312 link /test end_to_end

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16420, 16440)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants