Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an annotation to provide a route cookie #16454

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Use an annotation to provide a route cookie #16454

merged 2 commits into from
Sep 26, 2017

Commits on Sep 22, 2017

  1. Use an annotation to provide a route cookie 

    Route annotation:
router.openshift.io/cookie_name
can be used to set a cookie name for the route.

Added ROUTER_COOKIE_NAME for setting cookie name for all routes.

The cookie must pass regex filter `[a-zA-Z0-9_-]+`

https://trello.com/c/dZpU26W9
(3) Allow routes to set the cookie names for session stickiness
    @pecameron
    pecameron committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    3e6ed07 View commit details
    Browse the repository at this point in the history

  2. Change timeSpec name and coding 

    Change timeSpecRE to timeSpecPattern
Change " to `
Result:
$timeSpecPattern := `[1-9][0-9]*(us|ms|s|m|h|d)?`
    @pecameron
    pecameron committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    86171fe View commit details
    Browse the repository at this point in the history