Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fc fixes origin #16483

Merged
merged 3 commits into from
Sep 25, 2017
Merged

Conversation

rootfs
Copy link
Member

@rootfs rootfs commented Sep 21, 2017

Signed-off-by: Huamin Chen <hchen@redhat.com>
…e plugins

Signed-off-by: Huamin Chen <hchen@redhat.com>
Signed-off-by: Huamin Chen <hchen@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2017
@eparis
Copy link
Member

eparis commented Sep 21, 2017

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, rootfs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@rootfs
Copy link
Member Author

rootfs commented Sep 21, 2017

manually tested on FC nodes with two LUNs for two Pods. Both LUNs are detached and unmounted after pod deletion.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@eparis
Copy link
Member

eparis commented Sep 22, 2017

/retetst

@rootfs
Copy link
Member Author

rootfs commented Sep 22, 2017

@mtanino

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@eparis
Copy link
Member

eparis commented Sep 25, 2017

/retest

@rootfs
Copy link
Member Author

rootfs commented Sep 25, 2017

/test cmd

@rootfs
Copy link
Member Author

rootfs commented Sep 25, 2017

running test-cmd.sh locally didn't produce any error

SUCCESS after 0.184s: test/cmd/images.sh:106: executing 'oc create imagestreamtag tag-c:2 --from=mysql --from-image=mysql:latest' expecting failure and text '\--from and --from-image may not be used together'
SUCCESS after 0.199s: test/cmd/images.sh:108: executing 'oc get istag/tag:1 -o jsonpath={.image.dockerImageReference}' expecting success and text 'wildfly.*@sha256:'
SUCCESS after 0.198s: test/cmd/images.sh:110: executing 'oc get istag/tag-b:1 -o jsonpath={.image.metadata.name}' expecting success and text 'sha256:f6900d8ee65a802f6461a04c5e9f44e2fabbf6f09b2827260c643988bcdba16e'
SUCCESS after 0.195s: test/cmd/images.sh:111: executing 'oc get istag/tag:2 -o jsonpath={.image.dockerImageReference}' expecting success and text 'mysql@sha256:'
SUCCESS after 0.191s: test/cmd/images.sh:113: executing 'oc get is/tag -o 'jsonpath={.spec.tags[?(@.name=="3")].annotations.foo}'' expecting success and text 'bar'
SUCCESS after 0.194s: test/cmd/images.sh:114: executing 'oc get istag/tag:4 -o jsonpath={.image.metadata.name}' expecting success and text 'sha256:f6900d8ee65a802f6461a04c5e9f44e2fabbf6f09b2827260c643988bcdba16e'
SUCCESS after 0.204s: test/cmd/images.sh:115: executing 'oc get is/tag -o 'jsonpath={.spec.tags[?(@.name=="4")].from.name}'' expecting success and text '^2$'

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2017

@rootfs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd 6ce22c4 link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16490, 16483)

@openshift-merge-robot openshift-merge-robot merged commit 1bec7c1 into openshift:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants