Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bad exit #16534

Merged
merged 1 commit into from
Sep 25, 2017
Merged

remove bad exit #16534

merged 1 commit into from
Sep 25, 2017

Conversation

pweil-
Copy link
Contributor

@pweil- pweil- commented Sep 25, 2017

@soltysh looks like you left an exit in there #16128

cc @mfojtik

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2017
@pweil- pweil- requested a review from soltysh September 25, 2017 12:43
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Sep 25, 2017

@soltysh (!)

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, pweil-

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@bparees
Copy link
Contributor

bparees commented Sep 25, 2017

@pweil- @soltysh @mfojtik @stevekuznetsov how did the PR that introduced the exit 1 pass tests?

@stevekuznetsov
Copy link
Contributor

Looks like it's not run when we set up the server with Ansible, it's in the standup code

@pweil-
Copy link
Contributor Author

pweil- commented Sep 25, 2017

#13708
/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 4be0f20 into openshift:master Sep 25, 2017
@soltysh
Copy link
Member

soltysh commented Sep 26, 2017

@soltysh looks like you left an exit in there #16128

I feel sooo ashamed now 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants