Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded extension-apiserver-authentication-reader from service catalog example template. #16600

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Remove unneeded extension-apiserver-authentication-reader from service catalog example template. #16600

merged 1 commit into from
Oct 11, 2017
+0 −30

Conversation

jim-minter
Copy link
Contributor

Upstream role was added in #16517.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 28, 2017
@bparees
Copy link
Contributor

bparees commented Sep 28, 2017

needs bindata

@bparees
Copy link
Contributor

bparees commented Sep 28, 2017

/unassign
/assign @pmorie

@openshift-ci-robot openshift-ci-robot assigned pmorie and unassigned bparees Sep 28, 2017
@bparees
Copy link
Contributor

bparees commented Sep 28, 2017

/approve

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2017
Remove unneeded extension-apiserver-authentication-reader from servic…
036808f 
…e catalog example template.

Upstream role was added in openshift#16517.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2017
@jim-minter
Copy link
Contributor Author

@pmorie bump

@bparees
Copy link
Contributor

bparees commented Oct 9, 2017

/lgtm

@openshift/team-service-catalog fyi.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 11, 2017 •
edited

@jim-minter: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/experimental/integration 036808f link /test origin-it

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16600, 16722, 16760, 16784).

@openshift-merge-robot openshift-merge-robot merged commit 7bcfa0d into openshift:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmorie pmorie

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jim-minter @bparees @openshift-merge-robot @openshift-bot @openshift-ci-robot @pmorie