Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add statefulsets to PodForResource #16652

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Oct 3, 2017

Fixes: #16650

@smarterclayton PTAL

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 3, 2017
@0xmichalis
Copy link
Contributor

Lacks a test.

@mfojtik
Copy link
Contributor Author

mfojtik commented Oct 3, 2017

@Kargakis do we have any tests for PodForResource?

@0xmichalis
Copy link
Contributor

0xmichalis commented Oct 3, 2017

This needs a test in end-to-end since it's fixing cli functionality. Pretty sure we are testing rsh and logs there.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Oct 3, 2017

@Kargakis test added

@mfojtik
Copy link
Contributor Author

mfojtik commented Oct 3, 2017

flake: #16654

/retest

@mfojtik mfojtik added the kind/bug Categorizes issue or PR as related to a bug. label Oct 3, 2017
@0xmichalis
Copy link
Contributor

Awesome, thanks!

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kargakis, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16347, 16652).

@openshift-merge-robot openshift-merge-robot merged commit 7585e7e into openshift:master Oct 3, 2017
@smarterclayton
Copy link
Contributor

Thanks

@0xmichalis
Copy link
Contributor

/cherrypick stage

@openshift-cherrypick-robot

@Kargakis: PR 16652 failed to apply on top of branch "stage": exit status 128

In response to this:

/cherrypick stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xmichalis
Copy link
Contributor

/cherrypick release-3.6

@openshift-cherrypick-robot

@Kargakis: New pull request created: #17151

In response to this:

/cherrypick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants