Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 52168: Fix incorrect status msg in podautoscaler #16664

Commits on Oct 6, 2017

  1. UPSTREAM: 52168: Fix incorrect status msg in podautoscaler

    Fix #49256
    
    When `ScalingLimited = true` for the `hpa`, there is an accompanying
    status message, describing why scaling is limited. Previously if the desired
    replica count was 0, and spec.minReplicas > 0, the status message
    indicated "the desired replica count was less than the min replica
    count". This was particularly confusing when `spec.MinReplicas = 1`. If
    there was no `spec.minReplicas`, then the status message indicated "the
    desired replica count was zero" which is more informative.
    
    Update the calculation of status message so that if the desired replica
    count is 0, we always display the clearer "the desired replica count was
    zero" status message, even if spec.minReplicas > 0.
    
    Signed-off-by: mattjmcnaughton <mattjmcnaughton@gmail.com>
    mattjmcnaughton authored and DirectXMan12 committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    6de1772 View commit details
    Browse the repository at this point in the history