UPSTREAM: 52515: Clarify predicates name to clean confusing.

[aveshagarwal]

@sjenning @stevekuznetsov

The commits are a bit modified for 3.7. Also the title seems a bit confusing but I just copied it from upstream PR.

[stevekuznetsov]

I don't think I can make the approval call on the backport, but thank you for doing this.

/lgtm

[aveshagarwal]

flakes: #16802

[aveshagarwal]

flakes: #14385

[aveshagarwal]

The last one is spooky:

Result | FAILURE
-- | --
Tests | 0 failed / 6085 succeeded

[aveshagarwal]

/test unit
/test extended_networking_minimal
/test origin-ut

[aveshagarwal]

Thoough it shows that no failure:

Result | FAILURE
-- | --
Tests | 0 failed / 6084 succeeded

But there seems to be a failure here:

In suite "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/volume/flocker", test case "TestNewUnmounter" was skipped:
=== RUN   TestNewUnmounter
--- SKIP: TestNewUnmounter (0.00s)
	flocker_test.go:291: broken
[WARNING] While the jUnit report found no failed tests, the `go test` process failed.
[WARNING] This usually means that the unit test suite failed to compile.
[ERROR] hack/test-go.sh exited with code 2 after 00h 31m 43s
make: *** [test-unit] Error 2
[ERROR] PID 12616: hack/lib/build/environment.sh:166: `return "${exitcode}"` exited with status 2.
[INFO] 		Stack Trace: 
[INFO] 		  1: hack/lib/build/environment.sh:166: `return "${exitcode}"`
[INFO] 		  2: hack/lib/build/environment.sh:275: os::build::environment::withsource
[INFO] 		  3: hack/env:42: os::build::environment::run
[INFO]   Exiting with code 2.
++ export status=FAILURE
++ status=FAILURE
+ set +o xtrace
########## FINI

[aveshagarwal]

[WARNING] `go test` had the following output to stderr:
# github.com/openshift/origin/vendor/k8s.io/kubernetes/plugin/pkg/scheduler/core
vendor/k8s.io/kubernetes/plugin/pkg/scheduler/core/generic_scheduler_test.go:417: undefined: err in err.Error
vendor/k8s.io/kubernetes/plugin/pkg/scheduler/core/generic_scheduler_test.go:418: undefined: err in err.Error
[INFO] No compiled `junitreport` binary was found. Attempting to build one using:
[INFO]   $ hack/build-go.sh tools/junitreport
++ Building go targets for linux/amd64: tools/junitreport
[INFO] hack/build-go.sh exited with code 0 after 00h 00m 09s
[INFO] jUnit XML report placed at _output/scripts/test-go/artifacts/gotest_report_QkgkH.xml
Of 6103 tests executed in 2597.673s, 6084 succeeded, 0 failed, and 19 were skipped.
In suite "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/cloudprovider/pro

[aveshagarwal]

I think I found the issue, will update and submit.

[aveshagarwal]

flakes: #16810 and #16012 and #16812

/test integration

[aveshagarwal]

@sjenning @stevekuznetsov could you tag lgtm again?

[sjenning]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, sjenning, stevekuznetsov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [stevekuznetsov]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[aveshagarwal]

flakes: #16837, #16838

/test extended_conformance_gce

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[sjenning]

/test integration

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 15807, 16778, 16801, 16804, 16793).

[openshift-ci-robot]

@aveshagarwal: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install_update	e35de9a	link	/test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.