Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some diagnostic error handling (NetworkCheck and DiagnosticPod) #16848

Merged
merged 3 commits into from
Oct 16, 2017
Merged

Fix some diagnostic error handling (NetworkCheck and DiagnosticPod) #16848

merged 3 commits into from
Oct 16, 2017

Commits on Oct 12, 2017

  1. NetworkCheck: handle interrupt 

    fixes openshift#16847
    @sosiouxme
    sosiouxme committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    0ccc922 View commit details
    Browse the repository at this point in the history

  2. NetworkCheck: warn -> info on wrong network plugin 

    When the check can't run because the cluster is an all-in-one, this
shouldn't give a warning. Now it's an info.

It would be nice to put this in CanRun so the skip can be a Note but
given checking for the condition can raise its own error, it seemed
wisest to leave it until the diagnostic is running.
    @sosiouxme
    sosiouxme committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    83932a5 View commit details
    Browse the repository at this point in the history

  3. DiagnosticPod: handle interrupt

    @sosiouxme
    sosiouxme committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    4c90bb6 View commit details
    Browse the repository at this point in the history