UPSTREAM: 53916: update .dockercfg content to config.json

[juanvallejo]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1476330

update the data format of .dockercfg to match the new docker config.json
format, which encapsulates all registry auth objects in an overall
"auths" object when an option --config-format is specified with the value
--config-format=config.json:

{
    "auths": {
        "reg.url": {
            "auth": "...=="
        }
    }
}

cc @openshift/cli-review @bparees @mfojtik

[bparees]

1. this isn't an upstream feature?
2. any backwards compatibility concerns here?

[juanvallejo]

@bparees

this isn't an upstream feature?

Would it be better to just update DockerConfigEntry upstream / make a new object (maybe DockerAuthsEntry?) that stores DockerConfigEntry in a field named Auths?

any backwards compatibility concerns here?

Not entirely sure how to approach this, but an idea could be:

• Add a new flag (--config-format?) which would default to the legacy .dockercfg format
  or receive a value (config.json) that would output the new format instead

cc @fabianofranz @deads2k

[bparees]

Would it be better to just update DockerConfigEntry upstream / make a new object (maybe DockerAuthsEntry?) that stores DockerConfigEntry in a field named Auths?

I definitely don't think we want our implementation to diverge from the k8s one.

[juanvallejo]

@bparees thanks, went ahead and opened upstream pr - there was already a type upstream to represent the new auths format: https://github.com/kubernetes/kubernetes/blob/master/pkg/credentialprovider/config.go#L35.

Will update both PRs to only use the new format when a flag is given

[bparees]

thanks @juanvallejo

[juanvallejo]

@bparees @fabianofranz upstream PR has merged. ptal

[bparees]

lgtm but will let @fabianofranz sign off.

[fabianofranz]

/lgtm
/approve

[juanvallejo]

/assign derekwaynecarr

[deads2k]

/approve

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, fabianofranz, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[juanvallejo]

@fabianofranz this solves a cli blocker, wondering if we can add the "kind bug" label to this?

[juanvallejo]

/kind bug

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-merge-robot]

Automatic merge from submit-queue.