Adding sample Jenkins Pipeline #16880

coreydaley · 2017-10-15T21:11:56Z

Adding a sample Jenkins Pipeline in support of documentation updates.

Trello: https://trello.com/c/rBojNLGj/1121-5-better-devguide-pipeline-docs-techdebt

coreydaley · 2017-10-15T21:13:27Z

bparees

this not a "detailed walkthrough/example of building/deploying/promoting an application via a pipeline." (from the trello card).

it's also using the legacy plugin logic ("openshiftBuild", "openshiftVerifyBuild", etc) when it should be using only the openshift client plugin.

bparees · 2017-10-16T06:51:00Z

examples/jenkins/pipeline/nodejs-sample-pipeline.yaml

+      jenkinsfile: |-
+        try {
+           timeout(time: 20, unit: 'MINUTES') {
+             // run this pipeline on a node.js slave pod


align this w/ the next line.

bparees · 2017-10-16T06:52:45Z

examples/jenkins/pipeline/nodejs-sample-pipeline.yaml

+                      // setup to check if the objects from the template have already been created
+                      def templateGeneratedSelector = openshift.selector('all,secret', [ template: 'nodejs-mongodb-example' ])
+                      def objectsGeneratedFromTemplate = templateGeneratedSelector.exists()
+                      def objectModels = openshift.process( template )


no reason to process the template if the objects already exist.

bparees · 2017-10-16T07:12:52Z

this not a "detailed walkthrough/example of building/deploying/promoting an application via a pipeline." (from the trello card).

some additional information on why i say this... all this pipeline is doing is deploying a template if the template was not previously deployed. That's not a useful workflow for someone trying to iterate on developing an application because it's not going to update things if their template has changed.

it's also not demonstrating promotion.

what would make more sense:

delete everything w/ the template label (so we get a fresh start)
deploy the template
verify it built/deployed/is accessible (should build w/ a tag like :dev)
tag the newly built image as :stage
comments indicating that the stage environment should trigger off/pick up the newly available image. (no need to implement/demonstrate the actual stage deployment, sufficient to show the image is available for the stage env)

and it should be done using the openshift client plugin semantics, not the openshift pipeline plugin ones.

coreydaley · 2017-10-22T03:38:50Z

@bparees @gabemontero ptal

bparees

by reusing an existing template you've created a somewhat unnatural pipeline definition. i think it would be better to have your own template, or to invoke oc new-app to construct all the resources dynamically.

bparees · 2017-10-23T08:58:35Z

examples/jenkins/pipeline/nodejs-sample-pipeline.yaml

+                }
+                stage('create') {
+                  // create a new template from the templatePath
+                  def template = openshift.create(templatePath).object()


you shouldn't need to create the template to process it.

bparees · 2017-10-23T09:03:08Z

examples/jenkins/pipeline/nodejs-sample-pipeline.yaml

+                  for (o in objectModels) {
+                    // update the output image to be tagged with 'dev'
+                    if (o.kind == "BuildConfig") {
+                      o.spec.output.to.name = "${templateName}:dev"


why doesn't the template just define it this way?

bparees · 2017-10-23T09:03:26Z

examples/jenkins/pipeline/nodejs-sample-pipeline.yaml

+                      for (t in o.spec.triggers) {
+                        // set the deployment config to deploy the image tagged with 'dev'
+                        if (t.type == "ImageChange") {
+                          t.imageChangeParams.from.name = "${templateName}:dev"


why doesn't the template just define it this way?

gabemontero

I've got nothing new to add other than two of the points I raised in the associated doc PR ... I'll reiterate here for convenience:

long term we should monitor if adding a Jenkinsfile along these lines in our -ex repos makes sense
if not now, at some point soon we'll need a declarative pipeline syntax example

coreydaley · 2017-10-23T21:08:46Z

Updated example to use declarative pipeline syntax

coreydaley · 2017-10-24T02:21:02Z

/retest

coreydaley · 2017-10-24T16:09:28Z

/retest

gabemontero · 2017-10-24T19:18:16Z

/lgtm

coreydaley · 2017-10-25T02:11:30Z

@bparees ptal, all tests are passing

bparees · 2017-10-25T09:10:11Z

examples/jenkins/pipeline/nodejs-sample-pipeline.yaml

+kind: "BuildConfig"
+apiVersion: "v1"
+metadata:
+  name: "sample-nodejs-pipeline"


align this name and the filename.

updated, thought i had already fixed that, must have been in the docs

bparees · 2017-10-25T09:12:15Z

examples/jenkins/pipeline/nodejs-sample-pipeline.yaml

+                    // if everything else succeeded, tag the ${templateName}:latest image as ${templateName}:stage
+                    // a pipeline build config for the staging environment can watch for the ${templateName}:stage
+                    // image to change and then deploy it to the staging environment
+                    openshift.tag("${templateName}:latest", "${templateName}:stage")


you need to tag this into a different imagestream because your cleanup logic deletes the ${templateName} imagestream every time. And having a pipeline that deletes the "last good" tag as its first step is not logical.

(also updated the example in the docs)

bparees · 2017-10-25T15:46:46Z

/lgtm

openshift-merge-robot · 2017-10-25T15:46:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~examples/jenkins/OWNERS~~ [bparees]
~~pkg/oc/bootstrap/OWNERS~~ [bparees]
~~test/extended/OWNERS~~ [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Adding sample Jenkins Pipeline using declarative syntax Adding a sample Jenkins Pipeline in support of documentation updates. Trello: https://trello.com/c/rBojNLGj/1121-5-better-devguide-pipeline-docs-techdebt

coreydaley · 2017-10-26T19:37:12Z

/retest

openshift-bot · 2017-10-26T23:49:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2017-10-27T09:54:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

coreydaley · 2017-10-27T14:20:03Z

/retest

coreydaley · 2017-10-27T16:46:58Z

/retest

0xmichalis · 2017-10-27T18:19:30Z

/cherrypick stage

openshift-ci-robot · 2017-10-27T18:19:32Z

@Kargakis: @Kargakis once the present PR merges, I will cherry-pick it on top of stage in a new PR and assign it to you.

In response to this:

/cherrypick stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2017-10-27T19:24:22Z

Automatic merge from submit-queue.

coreydaley · 2017-10-28T13:36:23Z

(5) Better Dev_Guide Pipeline Docs [techdebt]

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2017

openshift-merge-robot assigned jim-minter and smarterclayton Oct 15, 2017

coreydaley mentioned this pull request Oct 15, 2017

Adding/updating Jenkins Pipeline documentation openshift/openshift-docs#5720

Merged

coreydaley assigned gabemontero and bparees and unassigned jim-minter and smarterclayton Oct 15, 2017

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2017

bparees requested changes Oct 16, 2017

View reviewed changes

bparees requested changes Oct 23, 2017

View reviewed changes

gabemontero reviewed Oct 23, 2017

View reviewed changes

gabemontero approved these changes Oct 24, 2017

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2017

bparees requested changes Oct 25, 2017

View reviewed changes

openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2017

bparees approved these changes Oct 25, 2017

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2017

openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2017

bparees added the kind/bug Categorizes issue or PR as related to a bug. label Oct 25, 2017

strip template prefix from TSB annotations

2d1bea7

Adding sample Jenkins Pipeline using declarative syntax Adding a sample Jenkins Pipeline in support of documentation updates. Trello: https://trello.com/c/rBojNLGj/1121-5-better-devguide-pipeline-docs-techdebt

openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2017

bparees added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2017

openshift-merge-robot merged commit 0f1a868 into openshift:master Oct 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding sample Jenkins Pipeline #16880

Adding sample Jenkins Pipeline #16880

coreydaley commented Oct 15, 2017 •

edited

Loading

coreydaley commented Oct 15, 2017

bparees left a comment

bparees Oct 16, 2017

bparees Oct 16, 2017

bparees commented Oct 16, 2017

coreydaley commented Oct 22, 2017

bparees left a comment

bparees Oct 23, 2017

bparees Oct 23, 2017

bparees Oct 23, 2017

gabemontero left a comment

coreydaley commented Oct 23, 2017

coreydaley commented Oct 24, 2017

coreydaley commented Oct 24, 2017

gabemontero commented Oct 24, 2017

coreydaley commented Oct 25, 2017

bparees Oct 25, 2017

coreydaley Oct 25, 2017

bparees Oct 25, 2017

coreydaley Oct 25, 2017

coreydaley Oct 25, 2017

bparees commented Oct 25, 2017

openshift-merge-robot commented Oct 25, 2017

coreydaley commented Oct 26, 2017

openshift-bot commented Oct 26, 2017

openshift-bot commented Oct 27, 2017

coreydaley commented Oct 27, 2017

coreydaley commented Oct 27, 2017

0xmichalis commented Oct 27, 2017

openshift-ci-robot commented Oct 27, 2017

openshift-merge-robot commented Oct 27, 2017

coreydaley commented Oct 28, 2017

Adding sample Jenkins Pipeline #16880

Adding sample Jenkins Pipeline #16880

Conversation

coreydaley commented Oct 15, 2017 • edited Loading

coreydaley commented Oct 15, 2017

bparees left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bparees commented Oct 16, 2017

coreydaley commented Oct 22, 2017

bparees left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabemontero left a comment

Choose a reason for hiding this comment

coreydaley commented Oct 23, 2017

coreydaley commented Oct 24, 2017

coreydaley commented Oct 24, 2017

gabemontero commented Oct 24, 2017

coreydaley commented Oct 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bparees commented Oct 25, 2017

openshift-merge-robot commented Oct 25, 2017

coreydaley commented Oct 26, 2017

openshift-bot commented Oct 26, 2017

openshift-bot commented Oct 27, 2017

coreydaley commented Oct 27, 2017

coreydaley commented Oct 27, 2017

0xmichalis commented Oct 27, 2017

openshift-ci-robot commented Oct 27, 2017

openshift-merge-robot commented Oct 27, 2017

coreydaley commented Oct 28, 2017

coreydaley commented Oct 15, 2017 •

edited

Loading