-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't run conformance tests w/ serial unless they are part of the focus #16919
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test extended_builds |
@smarterclayton @stevekuznetsov @miminar @jim-minter I firmly believe this is the right solution to our current e2e serial testing w/ focus problem. I know the long term vision is a separate serial suite (and ultimately no serial tests at all) but for now this gets the behavior closer to correct at a minimal cost, with minimal complexity, while preserving the ability to run focused tests on serial items. |
Several of the serial tests can't be focused with that. But I'm fine if
this fits your immediate need.
Stop using serial.
On Oct 17, 2017, at 11:04 PM, Ben Parees <notifications@github.com> wrote:
@smarterclayton <https://github.com/smarterclayton> @stevekuznetsov
<https://github.com/stevekuznetsov> @miminar <https://github.com/miminar>
@jim-minter <https://github.com/jim-minter> I firmly believe this is the
right solution to our current e2e serial testing w/ focus problem. I know
the long term vision is a separate serial suite (and ultimately no serial
tests at all) but for now this gets the behavior closer to correct at a
minimal cost, with minimal complexity, while preserving the ability to run
focused tests on serial items.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16919 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p9PF5y5ndcZcFOu_17fCOoBRI-3wks5stRZXgaJpZM4P80BJ>
.
|
/retest |
getting rid of the build test one here: registry ones are going to be a harder slog. |
/retest Please review the full test history for this PR and help us cut down flakes. |
does this close #16626? |
@bparees: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue. |
fixes #16626