Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stage] UPSTREAM: 52503: Get fallback termination msg from docker when using journald log driver #16920

Closed
wants to merge 1 commit into from
Closed

[stage] UPSTREAM: 52503: Get fallback termination msg from docker when using journald log driver #16920

wants to merge 1 commit into from

Conversation

joelsmith
Copy link
Contributor

xref #16912

@joelsmith
UPSTREAM: 52503: Get fallback termination msg from docker when using …
bb4b353 
…journald log driver

When using the legacy docker container runtime and when a container has
terminationMessagePolicy=FallbackToLogsOnError and when docker is
configured with a log driver other than json-log (such as journald),
the kubelet should not try to get the container's log from the
json log file (since it's not there) but should instead ask docker for
the logs.
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 17, 2017
@joelsmith joelsmith added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2017
@joelsmith
Copy link
Contributor Author

/test end_to_end

@joelsmith joelsmith changed the title UPSTREAM: 52503: Get fallback termination msg from docker when using journald log driver [stage] UPSTREAM: 52503: Get fallback termination msg from docker when using journald log driver Oct 18, 2017
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2017
@derekwaynecarr
Copy link
Member

/approve

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, joelsmith, sjenning

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2017
@derekwaynecarr
Copy link
Member

not needed for stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjenning sjenning

@smarterclayton smarterclayton

@derekwaynecarr derekwaynecarr

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@joelsmith @sjenning @derekwaynecarr @openshift-merge-robot @smarterclayton @stevekuznetsov @openshift-ci-robot