strip template prefix from TSB annotations

[bparees]

fixes #16755

[bparees]

/assign @jim-minter
/unassign @gabemontero @danwinship

@jim-minter ptal, i will need to update the upstream templates too but i wanted to at least ensure all the local ones are consistent with the new code first. Once this merges i'll update the upstream templates.

[bparees]

/retest

[bparees]

/retest

[jim-minter]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• examples/db-templates/OWNERS [bparees]
• examples/jenkins/OWNERS [bparees]
• examples/quickstarts/OWNERS [bparees]
• pkg/OWNERS [bparees]
• test/extended/OWNERS [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[jim-minter]

@bparees have lgtm'd this, but wondering why you didn't straight remove the consts from pkg/template/apis/template/constants.go?

[bparees]

@bparees have lgtm'd this, but wondering why you didn't straight remove the consts from pkg/template/apis/template/constants.go?

i'm leaving support for the old values in the TSB until i get the upstream templates updates to not use it. some loose semblance of backwards compatibility.

but i'll remove it before 3.7 ships.

@rcernich fyi, not sure if your templates have the template.openshift.io annotations in them, but we're renaming them as seen here.

[rcernich]

@bparees, will the old annotations continue to work? Which version is this change targeted at?

[bparees]

@bparees, will the old annotations continue to work? Which version is this change targeted at?

@rcernich the old annotations will not continue to work, we're just changing the behavior since we never supported the old behavior. this will be the first time the TSB GAs. this will be for 3.7.

[rcernich]

@bparees, thanks. Looks like we're not using the "template" prefix, so hopefully, we're good to go.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[bparees]

/retest

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 16943, 16872, 16916, 16863, 16925).