Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc cluster up: fix "No log available from 'origin' container" #17006

Merged

Conversation

php-coder
Copy link
Contributor

@php-coder php-coder commented Oct 23, 2017

oc cluster up fails on my machine and doesn't show the logs:

   Error: cannot add privileged SCC to pvinstaller service account
   Details:
     No log available from "origin" container

I see the following error, when I'm running it with --loglevel=8:

I1023 18:54:53.723538   13327 helper.go:206] Error getting container "origin" log: Error response from daemon: {"message":"Bad parameters: you must choose at least one stream"}

This PR fixes Bad parameters: you must choose at least one stream error by requesting stdout and stderr streams from Docker API.

PTAL @csrwng
CC @simo5

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2017
@php-coder
Copy link
Contributor Author

Test flake #16273
/test cmd

@csrwng
Copy link
Contributor

csrwng commented Oct 23, 2017

/lgtm thx!

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2017
@stevekuznetsov
Copy link
Contributor

/test origin-ct

@php-coder
Copy link
Contributor Author

@bparees PTAL. It's a bug, the fix is simple and this PR needs an LGTM to be merged.

@bparees bparees added the kind/bug Categorizes issue or PR as related to a bug. label Oct 24, 2017
@bparees
Copy link
Contributor

bparees commented Oct 24, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, csrwng, php-coder

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 230b6a1 into openshift:master Oct 24, 2017
@php-coder php-coder deleted the fix_oc_cluster_up_logs branch October 24, 2017 18:01
@0xmichalis
Copy link
Contributor

/cherrypick stage

@openshift-ci-robot
Copy link

@Kargakis: PR 17006 failed to apply on top of branch "stage": exit status 128

In response to this:

/cherrypick stage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xmichalis
Copy link
Contributor

/cherrypick release-3.6

@openshift-ci-robot
Copy link

@Kargakis: PR 17006 failed to apply on top of branch "release-3.6": exit status 128

In response to this:

/cherrypick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants