Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 51750: output <none> for colums not found #17023

Conversation

juanvallejo
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505796

Picks changes introduced in kubernetes/kubernetes#51750
to allow the custom-columns to succeed / print all known column values even when
an object's field does not exist.

Before

$ oc get dc mydc -o custom-columns=NAME:.metadata.name,UNKNOWN:.metadata.unknown
error: unknown is not found

After

$ oc get dc mydc -o custom-columns=NAME:.metadata.name,UNKNOWN:.metadata.unknown
NAME      UNKNOWN
mydc      <none>

cc @openshift/cli-review

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 24, 2017
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2017
@fabianofranz
Copy link
Member

/assign

@fabianofranz
Copy link
Member

/lgtm
/assign liggitt
for approval

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2017
@fabianofranz
Copy link
Member

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 24, 2017
@juanvallejo
Copy link
Contributor Author

/test extended_conformance_gce

@liggitt
Copy link
Contributor

liggitt commented Oct 25, 2017

/approve

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, juanvallejo, liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2017
@juanvallejo
Copy link
Contributor Author

/test extended_conformance_gce

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16885, 17023).

@openshift-merge-robot openshift-merge-robot merged commit d29dd8e into openshift:master Oct 25, 2017
@juanvallejo juanvallejo deleted the jvallejo/pick-upstream-51750 branch October 25, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants