prevent client from looking up specific node in oc debug
#17028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR openshift#16387 prevented a debug pod from being created at all, if a specified node-name pointed to a node that did not exist. Although the patch aimed to make "debug" command failures more immediate, a client should not attempt to retrieve a specific node in the "debug" command, as there is no guarantee that the user has access to retrieve node information. While this means that the "debug" command
openshift-ci-robot
added
the
size/S
juanvallejo
changed the title
oc debug
|
/lgtm |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianofranz, juanvallejo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/test extended_conformance_gce |
|
Automatic merge from submit-queue. |
|
/cherrypick stage |
|
@Kargakis: PR 17028 failed to apply on top of branch "stage": exit status 128 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16387
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505698
PR #16387 prevented a debug pod from being created at all, if a
specified node-name pointed to a node that did not exist.
Although the patch aimed to make "debug" command failures more
immediate, a client should not attempt to retrieve a specific node in
the "debug" command, as there is no guarantee that the user has access
to retrieve node information. While this means that the "debug" command
cc @openshift/cli-review @smarterclayton