Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speculative bump of gRPC to 1.2.1 to test for hangs #17723

Closed
wants to merge 2 commits into from

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Dec 12, 2017

@smarterclayton compilable version of #17720... i also bumped the grpc vendored by etcd.

@liggitt @soltysh FYI

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 12, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 12, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 12, 2017

@smarterclayton was the intent here mimic the changes in etcd-io/etcd#8867 ? I think we will require bump of etcd, don't think just the grpc bump will do the trick?

@bparees bparees removed their request for review December 12, 2017 14:40
@soltysh
Copy link
Member

soltysh commented Dec 12, 2017

+1 for etcd bump, which seems easier, esp. that we don't carry any patches anymore, iirc

@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 12, 2017

/test all

@openshift-ci-robot
Copy link

@mfojtik: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 57f5eaa link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install 57f5eaa link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Contributor

I'm not sure we should be bumping the Kube gRPC version. The risk of breaking the node is too high.

@mfojtik mfojtik closed this Jan 23, 2018
@mfojtik mfojtik deleted the bump_grpc branch September 5, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants