Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 58753: Fix kubectl explain for cronjobs #18268

Merged
merged 2 commits into from
Feb 5, 2018

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Jan 24, 2018

Fixes #18261.

@Kargakis fyi
/assign @juanvallejo

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Jan 24, 2018
@juanvallejo
Copy link
Contributor

Mind adding a case for cronjobs in our test as well? https://github.com/openshift/origin/blob/master/test/cmd/explain.sh

@soltysh
Copy link
Member Author

soltysh commented Jan 25, 2018

Added.

@0xmichalis
Copy link
Contributor

/retest

@deads2k
Copy link
Contributor

deads2k commented Feb 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2018
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18415, 18419, 18268, 18102, 18440).

@openshift-merge-robot openshift-merge-robot merged commit 797fbde into openshift:master Feb 5, 2018
@soltysh soltysh deleted the issue18261 branch February 6, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants