Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for lease acquisition that indicates the controllers and schedul… #18338

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 29, 2018

…er have successfully started

@mfojtik you had an issue for CRQ in test-cmd. In all instances I saw that we had not started the controllers, leading me to suspect that our reconciliation controllers are not running and reducing the count.

I've added code here that checks to make sure the lease is present before continuing.

/assign @mfojtik

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jan 29, 2018

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Jan 30, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Jan 30, 2018

This is low risk and the second biggest flake in the system, manually merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants