-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Header used for impersonation scopes #18378
Conversation
pkg/cmd/server/origin/handlers.go
Outdated
@@ -155,10 +154,12 @@ func (c *MasterConfig) versionSkewFilter(handler http.Handler, contextMapper api | |||
}) | |||
} | |||
|
|||
const legacyImpersonateUserScopeHeader = "Impersonate-User-Scope" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Godoc explaining that older servers respected this. We switched to the new way in 1q 2017.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -27,16 +30,18 @@ func newImpersonatingRoundTripper(user user.Info, delegate http.RoundTripper) ht | |||
|
|||
func (rt *impersonatingRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you were going to remove this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
@deads2k the last force push should be final, PTAL |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
Flake #12072 |
Note: the upstream function does not forcibliy remove potential existing impersonation headers, and it also uses the existing ones ignoring any new headers we may be setting. This i ok, because we do not depend nor probably want to allow multiple levels of impersonation. Signed-off-by: Simo Sorce <simo@redhat.com>
Just rebased |
@simo5: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, knobunc, simo5 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Flake #18412 |
Flake #18136 |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Fixes #18374