Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure we can unbind a deleted templateinstance #18452

Merged
merged 1 commit into from
Feb 7, 2018
Merged

make sure we can unbind a deleted templateinstance #18452

merged 1 commit into from
Feb 7, 2018

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Feb 5, 2018 •
edited

won't pass tests until #18416 has merged and new images are pushed.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2018
@bparees
Copy link
Contributor Author

bparees commented Feb 5, 2018

/assign @jim-minter
/unassign @mfojtik @stevekuznetsov

@jim-minter
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees changed the title make sure we can unbind a delete templateinstance make sure we can unbind a deleted templateinstance Feb 5, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@bparees bparees added retest-not-required lgtm Indicates that a PR is ready to be merged. labels Feb 7, 2018
@stevekuznetsov
Copy link
Contributor

/lgtm cancel

No need to keep running tests on this until prerequisites are fulfilled?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2018
@bparees
Copy link
Contributor Author

bparees commented Feb 7, 2018

the pre-reqs are fulfilled.
#18416 is merged.

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2018
@bparees
Copy link
Contributor Author

bparees commented Feb 7, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 886a811 into openshift:master Feb 7, 2018
@bparees bparees deleted the tsb_test branch February 9, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@jim-minter jim-minter

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bparees @jim-minter @openshift-bot @openshift-ci-robot @stevekuznetsov @openshift-merge-robot