make oadm router and registry resiliant to missing client #18546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/M
mfojtik
reviewed
Feb 9, 2018
| return fmt.Errorf("can't check for existing docker-registry %q: %v", name, err) | ||
| } | ||
| if opts.Config.Action.DryRun { | ||
| return fmt.Errorf("Docker registry %q service does not exist", name) |
|
/lgtm |
deads2k
force-pushed
the
up-07-routerregistry
branch
from
8f8df53
to
e1e8acf
Compare
|
Reworked to add a @mfojtik take another look? |
openshift-ci-robot
added
size/L
deads2k
force-pushed
the
up-07-routerregistry
branch
from
3b12470
to
a509e41
Compare
|
/assign @mfojtik prereq for cluster up |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 18437, 18546, 18550, 18579). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oc adm router --dry-run -o yaml(and registry) shouldn't require an apiserver connection. This makes it tolerant for cluster up