Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 58177: Redesign and implement volume reconstruction work #18554

Merged
merged 1 commit into from
Feb 12, 2018
Merged

UPSTREAM: 58177: Redesign and implement volume reconstruction work #18554

merged 1 commit into from
Feb 12, 2018

Conversation

rootfs
Copy link
Member

@rootfs rootfs commented Feb 9, 2018

fix https://bugzilla.redhat.com/show_bug.cgi?id=1508578

Note, e2e test is not ported, because the dependency on kubernetes #56593

@childsb @gnufied @jsafrane

@rootfs
UPSTREAM: 58177: Redesign and implement volume reconstruction work
8d3fd8e 
Signed-off-by: Huamin Chen <hchen@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2018
@rootfs
Copy link
Member Author

rootfs commented Feb 9, 2018

/test

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 9, 2018
@jsafrane
Copy link
Contributor

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2018
@jsafrane
Copy link
Contributor

/assign @mfojtik
for approval

@mfojtik
Copy link
Contributor

mfojtik commented Feb 12, 2018

/approve no-issue

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mfojtik, rootfs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2018
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17866, 18518, 18554, 18534, 17759).

@openshift-merge-robot openshift-merge-robot merged commit 8fd1640 into openshift:master Feb 12, 2018
gnufied added a commit to gnufied/origin that referenced this pull request Mar 5, 2018
@gnufied
Revert "Merge pull request openshift#18554 from rootfs/pr-58177"
3f52dd0 
This reverts commit 8fd1640, reversing
changes made to 3522daf.
gnufied added a commit to gnufied/origin that referenced this pull request Mar 6, 2018
@gnufied
UPSTREAM: revert: <drop>: Revert "Merge pull request openshift#18554 …
3e958f4 
…from rootfs/pr-58177"

This reverts commit 8fd1640, reversing
changes made to 3522daf.
gnufied added a commit to gnufied/origin that referenced this pull request Mar 6, 2018
@gnufied
Revert "Merge pull request openshift#18554 from rootfs/pr-58177"
0fd1f88 
This reverts commit 8fd1640, reversing
changes made to 3522daf.
gnufied added a commit to gnufied/origin that referenced this pull request Mar 6, 2018
@gnufied
UPSTREAM: revert: <drop>: Revert "Merge pull request openshift#18554 …
06db1cb 
…from rootfs/pr-58177"

This reverts commit 8fd1640, reversing
changes made to 3522daf.
gnufied added a commit to gnufied/origin that referenced this pull request Mar 6, 2018
@gnufied
UPSTREAM: revert: <drop>: Revert "Merge pull request openshift#18554 …
ab034dd 
…from rootfs/pr-58177"

This reverts commit 8fd1640, reversing
changes made to 3522daf.
gnufied added a commit to gnufied/origin that referenced this pull request Mar 6, 2018
@gnufied
UPSTREAM: <drop>: Revert "Merge pull request openshift#18554 from roo…
fdafb1e 
…tfs/pr-58177"

This reverts commit 8fd1640, reversing
changes made to 3522daf.
eparis added a commit that referenced this pull request Mar 8, 2018
@eparis
Merge pull request #18849 from gnufied/revert-reconstruct-pr
804ba0b 
Revert "Merge pull request #18554 from rootfs/pr-58177"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mfojtik mfojtik

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rootfs @jsafrane @mfojtik @openshift-ci-robot @openshift-merge-robot