Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picks for volume manager #18636

Merged
merged 2 commits into from
Feb 16, 2018

Conversation

sjenning
Copy link
Contributor

Thanks to @jsafrane for these fixes

kubernetes/kubernetes#59873
kubernetes/kubernetes#59923

59923 modified from upstream because some logging levels where already higher in 1.9

xref https://bugzilla.redhat.com/show_bug.cgi?id=1538216

Fixes #17605
Fixes #17556

@derekwaynecarr

@sjenning sjenning added the kind/bug Categorizes issue or PR as related to a bug. label Feb 16, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 16, 2018
@sjenning sjenning removed the request for review from jsafrane February 16, 2018 05:09
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 16, 2018
@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2018
@jsafrane
Copy link
Contributor

Flake: #18626. But why in Projected test? I hope we don't have new flake.

    No API token found for service account "default", retry after the token is automatically created and added to the service account

@jsafrane
Copy link
Contributor

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Feb 16, 2018

/approve no-issue

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mfojtik, sjenning

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit e4f2115 into openshift:master Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
6 participants