Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 57202: Fix format string in describers #18810

Merged
merged 1 commit into from
Mar 6, 2018
Merged

UPSTREAM: 57202: Fix format string in describers #18810

merged 1 commit into from
Mar 6, 2018

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Mar 2, 2018

https://bugzilla.redhat.com/show_bug.cgi?id=1524379

This is so trivial that it could catch 3.9

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 2, 2018
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 2, 2018

/assign @deads2k
You're sig-cli approver upstream. This is trivial and should not break 3.9

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 2, 2018

/cherrypick release-3.9

@openshift-cherrypick-robot
Copy link

@jsafrane: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2018
@soltysh
Copy link
Contributor

soltysh commented Mar 5, 2018

/retest

@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jsafrane, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 5, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18666, 18810, 18430, 18517, 18653).

@openshift-merge-robot openshift-merge-robot merged commit fa91b09 into openshift:master Mar 6, 2018
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2018
Merged
@openshift-cherrypick-robot
Copy link

@jsafrane: new pull request created: #18853

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot added a commit that referenced this pull request Mar 8, 2018
@openshift-merge-robot
Merge pull request #18853 from openshift-cherrypick-robot/cherry-pick…
c43888d 
…-18810-to-release-3.9

Automatic merge from submit-queue.

[release-3.9] UPSTREAM: 57202: Fix format string in describers

This is an automated cherry-pick of #18810

Fixes: http://bugzilla.redhat.com/show_bug.cgi?id=1524379

/assign jsafrane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jsafrane @openshift-cherrypick-robot @soltysh @openshift-ci-robot @openshift-merge-robot @deads2k