Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all nodes to run upstream kube tests #18842

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

jpeeler
Copy link
Contributor

@jpeeler jpeeler commented Mar 5, 2018

This is extracted from #18816 in order
to make hostpath tests pass.

This is extracted from openshift#18816 in order
to make hostpath tests pass.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2018
@jpeeler
Copy link
Contributor Author

jpeeler commented Mar 5, 2018

/test unit

@jpeeler
Copy link
Contributor Author

jpeeler commented Mar 5, 2018

@deads2k PTAL - once both PRs pass the gcp test (and merge), I'll close #18823

@deads2k
Copy link
Contributor

deads2k commented Mar 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2018
@deads2k
Copy link
Contributor

deads2k commented Mar 5, 2018

end to end doesn't hit this path. All other CI is green. This unblocks the queue. Merging

@deads2k
Copy link
Contributor

deads2k commented Mar 5, 2018

@smarterclayton if you decide you don't want this in your pull, you'll want to revert his too.

@deads2k deads2k merged commit b8a6e27 into openshift:master Mar 5, 2018
@openshift-ci-robot
Copy link

@jpeeler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/end_to_end 541aea6 link /test end_to_end

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/critical-fix size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants