Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: <carry>: ensure hijackedConn implements CloseWrite function #18882

Merged
merged 1 commit into from
Mar 7, 2018
Merged

UPSTREAM: <carry>: ensure hijackedConn implements CloseWrite function #18882

merged 1 commit into from
Mar 7, 2018

Conversation

jim-minter
Copy link
Contributor

@jim-minter jim-minter commented Mar 7, 2018 •
edited by bparees
Loading

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 7, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2018
@bparees
Copy link
Contributor

bparees commented Mar 7, 2018

@derekwaynecarr @mrunalp ptal

@bparees
Copy link
Contributor

bparees commented Mar 7, 2018

@deads2k how does this play with glide up now updating everything?

@mrunalp
Copy link
Member

mrunalp commented Mar 7, 2018

👍

@bparees
Copy link
Contributor

bparees commented Mar 7, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2018
@deads2k
Copy link
Contributor

deads2k commented Mar 7, 2018

@deads2k how does this play with glide up now updating everything?

We can sort it out after we fix our queue. It's some work.

@mfojtik

@deads2k
Copy link
Contributor

deads2k commented Mar 7, 2018

@mfojtik I created https://github.com/openshift/moby-moby/tree/b68221c as a spot to start the fork from. I'm not yet familiar with the commit format for the bot

@deads2k deads2k mentioned this pull request Mar 7, 2018
Closed
@liggitt liggitt mentioned this pull request Mar 7, 2018
Closed
@bparees bparees mentioned this pull request Mar 7, 2018
Closed
@gabemontero gabemontero mentioned this pull request Mar 7, 2018
Merged
@bparees bparees merged commit 9b2f3ac into openshift:master Mar 7, 2018
@jim-minter jim-minter mentioned this pull request Mar 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/critical-fix retest-not-required size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conformance_install tests wedging
6 participants
@jim-minter @bparees @mrunalp @openshift-ci-robot @deads2k @openshift-merge-robot