Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] UPSTREAM: 61045: subpath fixes #18957

Merged
merged 3 commits into from
Mar 14, 2018
Merged

[3.9] UPSTREAM: 61045: subpath fixes #18957

merged 3 commits into from
Mar 14, 2018

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Mar 12, 2018

Addresses CVE-2017-1002101 (CVE-2017-1002102 already addressed by #18255 and #18789)

Adds feature gating for subpath so as admins can
optionally disable it.
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 12, 2018
@liggitt liggitt changed the title UPSTREAM: 61045: subpath fixes [3.9] UPSTREAM: 61045: subpath fixes Mar 12, 2018
@liggitt liggitt added this to the v3.9 milestone Mar 12, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 12, 2018
@mfojtik
Copy link
Contributor

mfojtik commented Mar 13, 2018

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2018
@mfojtik
Copy link
Contributor

mfojtik commented Mar 13, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Contributor

mfojtik commented Mar 13, 2018

Flake: #18963

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor

@gnufied @childsb, please monitor this PR and pick kubernetes/kubernetes#61080 when it's merged, thanks.

(probably also to other origin branches)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2018
@mfojtik
Copy link
Contributor

mfojtik commented Mar 14, 2018

/retest

@jsafrane
Copy link
Contributor

/lgtm
for the new commits

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, liggitt, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@childsb
Copy link
Contributor

childsb commented Mar 14, 2018

/retest

@eparis
Copy link
Member

eparis commented Mar 14, 2018

that is an unrelated problem in gcp and an ansible install problem in install. merging by hand.

@eparis eparis merged commit a1d5364 into openshift:release-3.9 Mar 14, 2018
@openshift-ci-robot
Copy link

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp bb54af3 link /test gcp
ci/openshift-jenkins/extended_conformance_install bb54af3 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants