-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Paused' to ImageChangeTrigger for BuildConfig #19624
Add 'Paused' to ImageChangeTrigger for BuildConfig #19624
Conversation
yes we need to add a defaulter to default this field to true, or change the name to something like we'll have to sort that out along w/ the general shape of the api in your api PR. |
9f163e5
to
9721997
Compare
pending resolution of the api discussion, this looks reasonable to me (would need tests of course, but i wouldn't start writing those until the api is settled) |
also one question on the desired behavior of the api to be resolved here: |
62639da
to
8a07d6f
Compare
8a07d6f
to
fb9b3cb
Compare
80b4eb3
to
30d5e4b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wozniakjan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest flake |
/retest flake PROVISION CLOUD RESOURCES |
1 similar comment
/retest flake PROVISION CLOUD RESOURCES |
/retest |
/retest |
1 similar comment
/retest |
/retest
|
/retest |
@stevekuznetsov the GCP job keeps timing out here. I don't think this change could introduce such a regression that tests will start timing out, any ideas how to debug/fix? the job doesn't seem to exist in jenkins https://ci.openshift.redhat.com/jenkins/job/pull-ci-origin-launch-gcp/14/ (or maybe just the url is invalid?)
|
/retest |
@wozniakjan @php-coder @simo5 per some discussion w/ @deads2k we need to coordinate the two PRs that are picking up api changes, into a single PR. Specifically there is a new commit in api that needs to be picked up for anything to merge, so we need a single PR that picks up 1) the paused api change 2) @php-coder's api change and 3) @deads2k bug fix api change. @php-coder as i recall you were going to create your PR rebased on top of this PR, did you do that? If so, can you point us to the PR and is it ready for merge? It will need to be re-glide-up'd and rebased. If it's not ready for merge, we may need to consider another path to get this PR in. |
@bparees Here is my PR -- #18398 I've just tried to update it but couldn't make it work as @bparees @wozniakjan @deads2k Feel free to cherry-pick my commit(s) to use them in your PRs.
|
@wozniakjan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wozniakjan: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
this is being handled in #20152 |
When user adds
ICT
toBC
, theimage_trigger_controller.go
starts a build and this may not be desired for certain scenarios where specifically only change inImageStreamTag
should trigger the build. SettingPaused: true
tells the controller to not trigger the build.https://trello.com/c/iT4bw5jg/1541-3-ability-to-set-imagechange-triggers-in-buildconfig-without-triggering-a-build-automatically
cc: @openshift/sig-developer-experience, @openshift/sig-master
NOTE: This also changes the default behavior, which I think is probably not desired. For example, when useroc create -f [bc.yaml]
with ICT withoutAutomatic
field set, a build won't be triggered now. Maybe we would like to setAutomatic
field by default to true?TODO: