UPSTREAM: 65447: Resolve potential devicePath symlink when MapVolume #20117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
whoops, I am missing the patch that added EvalSymlinks to nsenter to begin with.... |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
wongma7
force-pushed
the
upstream-mapvolume-symlink
branch
2 times, most recently
from
b26013a
to
c116295
Compare
wongma7
force-pushed
the
upstream-mapvolume-symlink
branch
from
c116295
to
97205a6
Compare
openshift-ci-robot
added
size/L
|
/test unit |
|
We need also kubernetes/kubernetes#64426 since we are changing the mount interface & all fake mounters are affected |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
/assign @smarterclayton |
|
/approve |
|
@smarterclayton ping |
|
/approve |
|
/lgtm Over to you @smarterclayton |
|
/approve
…On Tue, Aug 21, 2018 at 3:50 PM OpenShift CI Robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *childsb
<#20117 (comment)>*, *jsafrane
<#20117 (comment)>*, *knobunc
<#20117 (comment)>*, *wongma7
<#20117#>*
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: *smarterclayton*
If they are not already assigned, you can assign the PR to them by writing /assign
@smarterclayton in a comment when ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- *vendor/k8s.io/kubernetes/pkg/OWNERS
<https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20117 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pzYF_BTSaVxiCC3u89m3Hlfa3WL9ks5uTGSKgaJpZM4U6Mc0>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: childsb, jsafrane, knobunc, smarterclayton, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to fix https://bugzilla.redhat.com/show_bug.cgi?id=1594201 for 3.11
I do not know how to test it with containerized kubelet, I assume our e2e will.
@openshift/sig-storage kindly review please ty.