-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set FileCheckFrequency default properly #20158
set FileCheckFrequency default properly #20158
Conversation
@@ -31,7 +31,7 @@ func ComputeKubeletFlags(startingArgs map[string][]string, options configapi.Nod | |||
imageTemplate.Latest = options.ImageConfig.Latest | |||
|
|||
path := "" | |||
var fileCheckInterval int64 | |||
fileCheckInterval := int64(20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want that or do you want to only conditionally set the flag at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set conditionally is better. i'll update it.
ef60ac0
to
ed83a54
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/test unit |
flake #20219 |
/retest |
1 similar comment
/retest |
/test cross |
removes the need for 91ff3a7
In 3.11, this code was reworked to use Ticker:
https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/kubelet/config/file.go#L63-L116
Whose panic exposed that we were defaulting the
--file-check-frequency
flag to 0 in thewrite-flags
:https://github.com/openshift/origin/blob/master/pkg/cmd/server/kubernetes/node/options/options.go#L34-L38
@deads2k @smarterclayton @derekwaynecarr